Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] Add --withdrawal_credentials flag #156

Open
wants to merge 2 commits into
base: hwwhww/add_key_check_test
Choose a base branch
from

Conversation

hwwhww
Copy link
Contributor

@hwwhww hwwhww commented Nov 10, 2020

based on #149 branch for the tests
fix #27

@hwwhww hwwhww changed the title Add --_withdrawal_credentials flag Add --withdrawal_credentials flag Nov 10, 2020
@hwwhww hwwhww changed the title Add --withdrawal_credentials flag [wip] Add --withdrawal_credentials flag Nov 10, 2020
@hwwhww hwwhww force-pushed the assign_withdrawal_credentials branch from f32c582 to 8710724 Compare November 10, 2020 17:45
@ujenjt
Copy link

ujenjt commented Nov 25, 2020

Hey, sorry for pinging you guys, I really really really wants this PR in the upstream. Please let me know if you need any help—I will be glad to work on moving this forward.

@hwwhww
Copy link
Contributor Author

hwwhww commented Dec 2, 2020

Another solution is to integrate @djrtwo's withdrawal to mnemonic PR. But it's also important to minimize the risks of user mistakes. Both solutions need to strongly warn users to be careful and KEEP BOTH DIFFERENT MNEMONICS so maybe it's safer to add a new command for this feature.

@CarlBeek @djrtwo Any thoughts on this feature?

@jack-crypto-id
Copy link

Another solution is to integrate @djrtwo's withdrawal to mnemonic PR. But it's also important to minimize the risks of user mistakes. Both solutions need to strongly warn users to be careful and KEEP BOTH DIFFERENT MNEMONICS so maybe it's safer to add a new command for this feature.

@CarlBeek @djrtwo Any thoughts on this feature?

if the problem is that the hash runs but the distribution of the tx hash is not continued, where is the problem, guys?

And I don't have a stake server yet.

@jack-crypto-id
Copy link

Okey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants